London | 26-ITP-Jan | Boualem Larbi Djebbour | sprint 3 | implement and rewrite tests coursework by djebsoft · Pull Request #1261 · CodeYourFuture/Module-Structuring-and-Testing-Data

djebsoft · 2026-03-13T03:42:47Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

implement and tests functions

Questions

Implemented the getAngleType function to classify angles and added tests for various angle types, including acute, obtuse, right, straight, reflex, and invalid angles.

… inputs

…nk is "10" so the string is 3 characters

…e the rank is "10" so the string is 3 characters" This reverts commit 82958b5.

…tion function

cjyuan · 2026-03-15T11:05:21Z

Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js

+  if (card[0] === "A") return 11;
+  if (["J", "Q", "K"].includes(card[0])) return 10;
+  if (["2", "3", "4", "5", "6", "7", "8", "9", "10"].includes(card[0]))
+    return card[0]; // the parseint() or Number() can be used to convert the string to a number
+  throw new Error("invalid rank");


Does your function return the value you expected from each of the following function calls?

getCardValue("+2♠"); getCardValue("2.0♠"); getCardValue("11♠"); getCardValue("2 ♠"); getCardValue("XYZ2♠");

cjyuan · 2026-03-15T11:06:06Z

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js

+  expect(getAngleType(-1)).toEqual("Invalid angle");
+  expect(getAngleType(0)).toEqual("Invalid angle");
+  expect(getAngleType(360)).toEqual("Invalid angle");
+  expect(getAngleType(361)).toEqual("Invalid angle");


Good job in identifying both boundary cases.

cjyuan · 2026-03-15T11:17:11Z

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js

+// case: the absolute value of the numerater is less than the absolute value of the denominater (proper fraction)
+test(`should return true for positive proper fraction`, () => {
+  expect(isProperFraction(1, 2)).toEqual(true);
+});
+
+// case: the absolute value of the denominater is less than the absolute value of the numerater (improper fraction)
+test(`should return false for positive improper fraction`, () => {
+  expect(isProperFraction(2, 1)).toEqual(false);
+});
+
+// no need to test the cases where the denominator or numerator or both are negative as I used their absolute value in the function.


In software industry, the test script we prepared may be used to test future implementation/modification. As a practice, can you also test negative numerator/denominator to make the tests comprehensive?

For proper fractions, the condition is, "the absolute value of denominator is larger than the absolute value of the numerator". So we can create a category for proper fractions and describe it as:
should return true when abs(numerator) < abs(denominator)
and then test all combinations of positive/negative numerator and denominator (for proper fraction) in this category.

cjyuan · 2026-03-15T11:20:40Z

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js

 test(`Should return 11 when given an ace card`, () => {
  expect(getCardValue("A♠")).toEqual(11);
 });
+test(`Should return 11 when given an ace card`, () => {
+  expect(getCardValue("A♥")).toEqual(11);
+});
+test(`Should return 11 when given an ace card`, () => {
+  expect(getCardValue("A♦")).toEqual(11);
+});
+test(`Should return 11 when given an ace card`, () => {
+  expect(getCardValue("A♣")).toEqual(11);
+});


It's a good idea to test all suit. I think you can combine these tests into a single category.

cjyuan · 2026-03-15T11:23:02Z

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js

+test(`Should return 2 when given a 2 card`, () => {
+  expect(getCardValue("2♠")).toEqual(2);
+});
+test(`Should return 3 when given a 3 card`, () => {
+  expect(getCardValue("3♥")).toEqual(3);
+});
+test(`Should return 4 when given a 4 card`, () => {
+  expect(getCardValue("4♦")).toEqual(4);
+});
+test(`Should return 5 when given a 5 card`, () => {
+  expect(getCardValue("5♣")).toEqual(5);
+});
+test(`Should return 6 when given a 6 card`, () => {
+  expect(getCardValue("6♥")).toEqual(6);
+});
+test(`Should return 7 when given a 7 card`, () => {
+  expect(getCardValue("7♠")).toEqual(7);
+});
+test(`Should return 8 when given a 8 card`, () => {
+  expect(getCardValue("8♦")).toEqual(8);
+});
+test(`Should return 9 when given a 9 card`, () => {
+  expect(getCardValue("9♠")).toEqual(9);
+});
+test(`Should return 10 when given a 10 card`, () => {
+  expect(getCardValue("10♣")).toEqual(10);
+});


Good idea to test all number cards.

You could also consider combining them into a single category (since they are all number cards), as:

test("should return the value of number cards (2-10)", () => { expect(getCardValue("2♣︎")).toEqual(2); ... expect(getCardValue("10♥")).toEqual(10); // or use a loop to check all values from 2 to 10. });

And perhaps one category for J, Q, K (face cards) and one category for invalid cases.

cjyuan · 2026-03-15T11:25:48Z

Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js

 function isProperFraction(numerator, denominator) {
  // TODO: Implement this function
+  if (Math.abs(numerator) < Math.abs(denominator)) {
+    return true;
+  } else {
+    return false;
 }


There seem to be a syntax error in this function.

…alues

djebsoft added 9 commits March 5, 2026 00:24

Implement getAngleType function and add tests

0c4631a

Implemented the getAngleType function to classify angles and added tests for various angle types, including acute, obtuse, right, straight, reflex, and invalid angles.

Implement a function getAngleType and Write tests to cover all cases

4a2804d

implement isproperfraction function and rewrite tests to cover all cases

6b4ee50

Implement getCardValue function and added tests for valid and invalid…

7d502dc

… inputs

validate the first if statement to include the condition there the ra…

82958b5

…nk is "10" so the string is 3 characters

Revert "validate the first if statement to include the condition ther…

c286e4a

…e the rank is "10" so the string is 3 characters" This reverts commit 82958b5.

add tests for all angle types and invalid angles

a70220f

Write tests in Jest syntax to cover all combinations for isProperFrac…

bc11ec7

…tion function

Write tests in Jest syntax to cover all possible outcomes.

7eab738

djebsoft added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 13, 2026

djebsoft mentioned this pull request Mar 14, 2026

ITP_Jan_2026 | Structuring and testing data| Boualem Larbi Djebbour djebsoft/My-Coursework-Planner#4

Open

cjyuan reviewed Mar 15, 2026

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Mar 15, 2026

djebsoft added 2 commits March 15, 2026 19:06

enhancement: Implement getCardValue function to return correct card v…

3f7c3f8

…alues

fixed syntax error

6769341

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

London | 26-ITP-Jan | Boualem Larbi Djebbour | sprint 3 | implement and rewrite tests coursework#1261

London | 26-ITP-Jan | Boualem Larbi Djebbour | sprint 3 | implement and rewrite tests coursework#1261
djebsoft wants to merge 11 commits intoCodeYourFuture:mainfrom
djebsoft:sprint-3/implement-and-rewrite-tests-coursework

djebsoft commented Mar 13, 2026

Uh oh!

cjyuan Mar 15, 2026

Uh oh!

cjyuan Mar 15, 2026

Uh oh!

cjyuan Mar 15, 2026

Uh oh!

cjyuan Mar 15, 2026

Uh oh!

cjyuan Mar 15, 2026

Uh oh!

cjyuan Mar 15, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

djebsoft commented Mar 13, 2026

Learners, PR Template

Changelist

Questions

Uh oh!

cjyuan Mar 15, 2026

Choose a reason for hiding this comment

Uh oh!

cjyuan Mar 15, 2026

Choose a reason for hiding this comment

Uh oh!

cjyuan Mar 15, 2026

Choose a reason for hiding this comment

Uh oh!

cjyuan Mar 15, 2026

Choose a reason for hiding this comment

Uh oh!

cjyuan Mar 15, 2026

Choose a reason for hiding this comment

Uh oh!

cjyuan Mar 15, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants